Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Observer are being triggered left and right when a model is saved, even if no value have been changed. #420

Closed
olivierchatry opened this issue Sep 1, 2016 · 1 comment

Comments

@olivierchatry
Copy link
Contributor

Version info

DEBUG: -------------------------------
DEBUG: Ember             : 2.7.2
DEBUG: Ember Data        : 2.7.0
DEBUG: Firebase          : 3.3.0
DEBUG: EmberFire         : 2.0.1
DEBUG: jQuery            : 2.2.4
DEBUG: Ember Simple Auth : 1.1.0
DEBUG: -------------------------------

Test case

Save any kind of model twice.

Steps to reproduce

Save any kind of model twice.

Expected behavior

Not observer should be called ( or property update ) on the second save, since no value have been changed.

Actual behavior

Observer are triggered, which make everything either very slow or not practical at all. You multiply that by the fact that relationships are saved on a different pass, and you obtain a callback nightmare.

@tstirrat
Copy link
Contributor

2.0.2 is released with #425, please re-open if there are any other issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants