Delayed pushes will only run once per record #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Make sense, I was a bit afraid of not merging new push with old push, but I guess Firebase always send the full update :). |
|
Yeah, I considered that. In this case we are always getting the new data from a |
|
Can't wait to have it on a new version then :) Should I close my other PR ? |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prevents thrashing of delayed
store.pushon the same record in short succession.@olivierchatry thanks for your work in #421, this is adapted from that. I improved it so that it handles duplicate pushes anywhere in the current queue, rather than only checking last payload. I also took the opportunity to clean up/rename the
_enqueuemethod which was only used for one purpose./see #420