Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix contains deprecation #464

Merged
merged 1 commit into from
Jan 4, 2017
Merged

Fix contains deprecation #464

merged 1 commit into from
Jan 4, 2017

Conversation

oskarrough
Copy link
Contributor

See #436.

I wasn't able to run tests before or after my change so I'd appreciate any input here.

jamesdaniels
jamesdaniels approved these changes Jan 4, 2017
View reviewed changes
Copy link
Contributor

@jamesdaniels jamesdaniels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jamesdaniels jamesdaniels merged commit 2ebeab9 into FirebaseExtended:master Jan 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesdaniels jamesdaniels jamesdaniels approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oskarrough @jamesdaniels