-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove lodash #502
Remove lodash #502
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
1 similar comment
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it! |
CLAs look good, thanks! |
1 similar comment
CLAs look good, thanks! |
Not sure what happened to Travis CI but I passed all test cases on my local machine. |
Yeah, looks like something got flaky. I've run tests locally for your branch, and all looks fine 👍 |
Lodash is giving the same deprecation warnings of Torii. Is it possible to fast-track this PR? |
I'm kicking this now with the switch to yarn, hopefully that helps the CI failures. |
Ack @Cryrivers, mind giving the failing tests a look now that we've locked it down with yarn? |
@jamesdaniels Any idea why all test cases can pass on my local machine but not Travis CI? |
@Cryrivers I'm gonna take a gander it has to do with cached node_modules https://travis-ci.org/firebase/emberfire/jobs/239540498/config |
Always do cleanups
@mileszim tried with no luck 😢 |
I tried correctly disabling caching by setting |
Ah! it's because travis is using Firefox 31. I'm not sure exactly what code is causing the problem though. |
I've submitted a PR that fixes the Firefox issue #516 and merged it into my copy of this lodash PR to check that it works, which it does! https://travis-ci.org/ibroadfo/emberfire/jobs/241726167 :) |
Thanks! |
nice work! thanks for getting this in! |
Description
As functions imported from Lodash have been already supported by either ECMAScript 5 or Ember framework, this PR removes Lodash to reduce the addon's size.