Neopixel demo #64
Neopixel demo #64
Conversation
|
looks pretty slick, I like the web preview. |
|
|
||
|
|
||
| // TODO: Replace with your own credentials and keep these safe. | ||
| Firebase fbase = Firebase("brilliant-fire-9638.firebaseio.com") |
There was a problem hiding this comment.
you might want to remove your secret from the sample :)
| Firebase fbase = Firebase("brilliant-fire-9638.firebaseio.com") | ||
| .auth("llXzJtqwdiHCHw6F6sehQR2EPwbO0YYdhEjPRZxG"); | ||
| Firebase fbase = Firebase("YOUR-PROJECT-ID.firebaseio.com") | ||
| .auth("YOUR_AUTH_SECRET"); |
There was a problem hiding this comment.
Maybe use the same placeholder that we use in the other sample:
https://github.com/googlesamples/firebase-arduino/blob/master/examples/FirebasePush_ESP8266/FirebasePush_ESP8266.ino#L23
Or change the other sample to use yours :) (I'm not sure Project ID is in firebase jargon)
|
Maybe you can rename the -web subfolder to just Maybe also add a README with the same description than this pull request. |
|
Just some nits, but LGTM. |
| With the dependencies set, serve the www folder from a web server. For example, | ||
| you can use the Python Simple HTTP server module by running: | ||
|
|
||
| `python -m SimpleHTTPServer [port]` |
There was a problem hiding this comment.
maybe you could use https://github.com/PolymerLabs/polyserve?
|
LGTM |
A basic demo of Web + Arduino control of an Adafruit Neopixel feather shield