-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for signInWithCredentials #73
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it! |
CLAs look good, thanks! |
"name": "polymerfire", | ||
"version": "0.9.4", | ||
"name": "polymerfire-extended", | ||
"version": "0.9.5", | ||
"authors": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think you can change the name of the project or version. That will be done by person responsible for maintaining this project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This changes are not part of my pull request. I need this changes to start using this component in my app. If i dont change this in the bower file i get the original component without my changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, you can use Bower's resolutions
for that, enabling you to download your version fernandezpaco/polymerfire
whenever it requires polymerfire
.
If you keep your pull request clean it can be merged, otherwise it needs to be replicated, because this commit cannot be merged this whole pull request cannot be merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, sorry. I have removed my changes from bower.json. I think is clean now, ready to be merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now i would say, you have to clean commit history, by squashing all those commits in to one.
git rebase
in help ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:) Thanks a lot for the guidance (My first pull request)
I think it is ok now
@polinom thanks for your help guiding this PR! |
LGTM |
Just exposing the signInWithCredential method in the polymer component.
Very useful when you already have an oauth id_token.