Postfix for #7989 - Improve performance of external (UDR) functions #8046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dyemanov
requested changes
Mar 17, 2024
| JRD_reschedule(tdbb); | ||
|
|
||
| function->fun_external->execute(tdbb, request, transaction, inMsgLength, inMsg, outMsgLength, outMsg); | ||
| } |
There was a problem hiding this comment.
Even if att_cancel_lock is active and cancellation request has been posted to our attachment, the external function cannot be cancelled during its execution. But maybe we should call tdbb->checkCancelState() immediately after its execution to react quickly? And maybe JRD_reschedule() will be not needed after that change, given that we always check out the engine during function invocation.
There was a problem hiding this comment.
Please see if it's now correct.
dyemanov
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing profiling, savepoint and stack traces.
It became slower than what initially done in #7989, but still much faster than v5.
I edited new timings verified in test in #7989.