Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add manual delete for tra_dbcreators_list #8207

Merged
merged 2 commits into from
Aug 6, 2024
Merged

Add manual delete for tra_dbcreators_list #8207

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e3014b3
Delete tra_dbcreators_list in ~jrd_tra
Aug 6, 2024
3fa7a93
Add missing default initialization for tra_dbcreators_list
Aug 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/jrd/tra.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3792,6 +3792,7 @@ jrd_tra::~jrd_tra()
delete tra_user_management;
delete tra_timezone_snapshot;
delete tra_mapping_list;
delete tra_dbcreators_list;
delete tra_gen_ids;

if (!tra_outer)
Expand Down
1 change: 1 addition & 0 deletions src/jrd/tra.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,6 +198,7 @@ class jrd_tra : public pool_alloc<type_tra>
tra_user_management(NULL),
tra_sec_db_context(NULL),
tra_mapping_list(NULL),
tra_dbcreators_list(nullptr),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not required as every class inherited from pool_alloc has its instance zero-initialized at creation. But I prefer us being more explicit in this regard, so this is a good thing for master.

tra_autonomous_pool(NULL),
tra_autonomous_cnt(0)
{
Expand Down
Loading