Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade ANTLR in Jaybird 4, or backport new parser of Jaybird 5 into Jaybird 4 #718

Closed
mrotteveel opened this issue Nov 26, 2022 · 1 comment

Comments

@mrotteveel
Copy link
Member

Jaybird 4 (and Jaybird 3) use ANTLR 4.7 for the generated keys facility. Unfortunately, ANTLR 4.10 introduced an incompatible change, changing the ATN version, which for example causes problems when trying to use Hibernate 6 in combination with Jaybird 4.

This results in an error:

java.io.InvalidClassException: org.antlr.v4.runtime.atn.ATN; Could not deserialize ATN with version 3 (expected 4).

We either need to upgrade to ANTLR 4.10 or higher (latest is 4.11.1), or backport #680 to Jaybird 4. Backporting is probably preferable as it avoids issues with people relying on earlier ANTLR versions for other things, but might introduce minor backwards incompatibilities with generated keys detection.

@mrotteveel
Copy link
Member Author

Decide to remove dependency on ANTLR and backport #680.

mrotteveel added a commit that referenced this issue Nov 26, 2022
Remove dependency on antlr-runtime-4.7.2.jar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant