Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double-check and fix completion behaviour of statements in auto-commit #806

Closed
mrotteveel opened this issue May 12, 2024 · 0 comments
Closed

Comments

@mrotteveel
Copy link
Member

While working on #805, I noticed that FBPreparedStatement.execute() does not properly commit the transaction in auto-commit if an exception is thrown. This needs to be fixed, and also verified for other execute and executeXXX methods.

To be clear, it should commit even though it failed. The JDBC specification explicitly says that in auto-commit mode, the transaction should be committed if statement execution finishes, and it doesn't mention anything about rolling back in case of failure. In general, Firebird will undo the effects of a statement that raised an error anyway.

Fix to be backported to v5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant