Add json docs #15
Merged
Add json docs #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TGiles
reviewed
Mar 8, 2024
| @@ -0,0 +1,60 @@ | |||
| # Design tokens | |||
There was a problem hiding this comment.
We need to change the JSON part of the name to lower case, otherwise the file doesn't show up
jsimplicio
force-pushed
the
add-json-docs
branch
from
a3d71e2 to
fa1f523
Compare
jsimplicio
force-pushed
the
add-json-docs
branch
from
fa1f523 to
4a86e33
Compare
mstriemer
reviewed
Mar 8, 2024
| Here's how to build design tokens for desktop: | ||
|
|
||
| ```sh | ||
| $ cd toolkit/…/design-system |
There was a problem hiding this comment.
Suggested change
| $ cd toolkit/…/design-system |
hannajones
reviewed
Mar 8, 2024
Comment on lines
2
to
4
| ## Source of truth | ||
| ### Background | ||
| The benefit of storing design tokens with a platform-agnostic format such as JSON is that it can be converted or translated into other languages or tools (e.g CSS, Swift, Kotlin, Figma). |
There was a problem hiding this comment.
Suggested change
| ## Source of truth | |
| ### Background | |
| The benefit of storing design tokens with a platform-agnostic format such as JSON is that it can be converted or translated into other languages or tools (e.g CSS, Swift, Kotlin, Figma). | |
| ### Background | |
| `design-tokens.json` is the source of truth for all our design tokens. The benefit of storing design tokens with a platform-agnostic format such as JSON is that it can be converted or translated into other languages or tools (e.g CSS, Swift, Kotlin, Figma). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds basic documentation behind the JSON design tokens.