Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message bar, component: add specs in the visuals #138

Closed
brassy- opened this issue Nov 1, 2017 · 5 comments
Closed

Message bar, component: add specs in the visuals #138

brassy- opened this issue Nov 1, 2017 · 5 comments
Assignees
Milestone

Comments

@brassy-
Copy link
Collaborator

brassy- commented Nov 1, 2017

Add some specs in the visual assets to increase the clarity of the page.

@brassy- brassy- self-assigned this Nov 1, 2017
@brassy- brassy- added this to the 2017.11.08 milestone Nov 1, 2017
brassy- added a commit that referenced this issue Nov 7, 2017
and we undrafted the message bar!
aminalhazwani pushed a commit that referenced this issue Nov 7, 2017
* 'staging' of github.com:FirefoxUX/photon:
  [fix] issue #132
  [add] new error icon! yay!
  [add] solved #138
  [fix] visual assets
  fix #134
  [add] tab crashed img
  [add] new visual for message bar
@brassy-
Copy link
Collaborator Author

brassy- commented Nov 8, 2017

Add error round icon to /icons website

@tinahsieh
Copy link

@brassy- I found a minor inconsistency that the way you describe colors is different from other pages. How about using Gray 90 instead of Gray-90?

@brassy-
Copy link
Collaborator Author

brassy- commented Nov 8, 2017 via email

@tinahsieh
Copy link

tinahsieh commented Nov 8, 2017

(Just leave it here) A few questions regarding the visual examples and content:

  1. Are these two message bars dismissable?

screen shot 2017-11-08 at 6 44 29 pm

  1. I felt a little confused about having 2 items in this image. Do we have the 2nd one because we need to mark some specs on it?

screen shot 2017-11-08 at 6 47 08 pm

  1. Button text in uppercase?

screen shot 2017-11-08 at 6 52 17 pm

@brassy-
Copy link
Collaborator Author

brassy- commented Nov 8, 2017

  1. Are these two message bars dismissable?

No.

  1. I felt a little confused about having 2 items in this image. Do we have the 2nd one because we need to mark some specs on it?

Good point, I'll update the image today.

  1. Button text in uppercase?

Fixing it right now, good catch!

brassy- added a commit that referenced this issue Nov 8, 2017
aminalhazwani pushed a commit that referenced this issue Nov 8, 2017
* 'staging' of github.com:FirefoxUX/photon:
  [add] link to error icon
  [fix] show just one icon for the icon usage example in mb #138
  [fix] misaligned #138
  [fix] remove an old reference to uppercase #138
  [update] node-sass dependency version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants