send GA event when toggling AND send events on interaction #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwinton
approved these changes
Jan 29, 2018
ericawright
force-pushed
the
specific-events
branch
3 times, most recently
from
5509474
to
4d17ab2
Compare
ericawright
changed the title
ericawright
force-pushed
the
specific-events
branch
from
4d17ab2
to
cd24d0b
Compare
aminalhazwani
approved these changes
Jan 30, 2018
| document.getElementById('showExample').style.display='block'; | ||
| return false;">Interactive example</a> (Currently only renders correctly in Firefox.) | ||
| </small> | ||
| <div class='interactive'> |
There was a problem hiding this comment.
Here it should probably be <div class="interactive"> instead of <div class='interactive'>, so double quotes instead of single quotes
| @@ -440,3 +440,83 @@ div[data-tabs] input[type="radio"]:checked + label { | |||
| div[data-tabs] input[type="radio"]:checked + label + div[data-tab] { | |||
| display: block; | |||
| } | |||
|
|
|||
| /* Interactive checkbox */ | |||
There was a problem hiding this comment.
I am wondering if these styles should live in a separate scss partial. I will leave it as it is and we can change it later if you agree 😃
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the iframe and builds the interactive example within our app, this way we can send click events interacting with the radio buttons.
type = 'click', event = "interaction-with-demo" and I'm also sending details, which is the nearest parent with an id - I'm sending it's id. for this example that is "select-unselect-example"
Fixes: #251.
** merge this OR the other, not both**