Skip to content
This repository has been archived by the owner on Mar 25, 2024. It is now read-only.

Finish deprecation of all U2F-specific classes #36

Open
wants to merge 21 commits into
base: master
Choose a base branch
from

Conversation

Firehed
Copy link
Owner

@Firehed Firehed commented Oct 27, 2021

The additions to the changelog best summarize this, but as all of the legacy u2f.js format support will be dropped in the next major release, all of the classes and related functionality surrounding them is being deprecated.

There's a pretty substantial amount of test updates that go along with this to decouple the server tests from the U2F-specific data formats, but #13 paved the way for that to happen.

@codecov
Copy link

codecov bot commented Oct 27, 2021

Codecov Report

Merging #36 (b9b8db5) into master (bbe2e40) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##              master       #36   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity       140       140           
===========================================
  Files             22        22           
  Lines            559       559           
===========================================
  Hits             559       559           
Impacted Files Coverage Δ
src/AppIdTrait.php 100.00% <ø> (ø)
src/ChallengeTrait.php 100.00% <ø> (ø)
src/ClientData.php 100.00% <ø> (ø)
src/KeyHandleTrait.php 100.00% <ø> (ø)
src/RegisterRequest.php 100.00% <ø> (ø)
src/RegisterResponse.php 100.00% <ø> (ø)
src/ResponseTrait.php 100.00% <ø> (ø)
src/Server.php 100.00% <ø> (ø)
src/SignRequest.php 100.00% <ø> (ø)
src/SignResponse.php 100.00% <ø> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbe2e40...b9b8db5. Read the comment docs.

@Firehed Firehed marked this pull request as ready for review October 27, 2021 23:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant