Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 8.4 stable and 8.5-dev to test matrix #88

Merged
merged 4 commits into from
Jan 8, 2025
Merged

Add 8.4 stable and 8.5-dev to test matrix #88

merged 4 commits into from
Jan 8, 2025

Conversation

Firehed
Copy link
Owner

@Firehed Firehed commented Nov 25, 2024

PHP 8.4 was released last week, so this updates the test matrix accordingly. 8.1 can be reasonably dropped as well.

8.4 and 8.5 are now emitting a deprecation warning from the ASN.1 library. I intend to send a PR, but there's been no activity for quite some time (understandable given the context of the library, but there's also an open PR for other language-related improvements) so switching to a more actively-maintained library may end up being a better choice.

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.26%. Comparing base (1031cc6) to head (02d65ae).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main      #88   +/-   ##
=========================================
  Coverage     81.26%   81.26%           
  Complexity      308      308           
=========================================
  Files            33       33           
  Lines          1025     1025           
=========================================
  Hits            833      833           
  Misses          192      192           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Firehed Firehed marked this pull request as ready for review January 8, 2025 17:51
@Firehed Firehed merged commit 4231fc7 into main Jan 8, 2025
14 checks passed
@Firehed Firehed deleted the php-8.4 branch January 8, 2025 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant