Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace GMP function calls with overloaded operators #90

Merged
merged 7 commits into from
Nov 26, 2024
Merged

Conversation

Firehed
Copy link
Owner

@Firehed Firehed commented Nov 26, 2024

Fixes #89 (though it really shouldn't).

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.26%. Comparing base (d324c80) to head (1729f17).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main      #90   +/-   ##
=========================================
  Coverage     81.26%   81.26%           
  Complexity      308      308           
=========================================
  Files            33       33           
  Lines          1025     1025           
=========================================
  Hits            833      833           
  Misses          192      192           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Firehed
Copy link
Owner Author

Firehed commented Nov 26, 2024

Seems fine other than phpstan/phpstan#12123. Might add some ignores to work through it

@Firehed Firehed marked this pull request as ready for review November 26, 2024 17:20
@Firehed Firehed changed the title Replace gmp functions with overloaded operators Replace GMP function calls with overloaded operators Nov 26, 2024
@Firehed Firehed merged commit 1031cc6 into main Nov 26, 2024
14 checks passed
@Firehed Firehed deleted the gmp-overflow branch November 26, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Key verification crashes under latest PHP versions
1 participant