Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added root resource to the evaluation context of FP invariant evaluation #353

Merged
merged 8 commits into from
Sep 12, 2024

Conversation

Kasdejong
Copy link
Contributor

@Kasdejong Kasdejong commented Aug 20, 2024

Description

Added root resource to the evaluation context of FP invariant evaluation

review FirelyTeam/fhir-test-cases#48 first

Related issues

Closes #327

@Kasdejong Kasdejong self-assigned this Aug 20, 2024
@Kasdejong Kasdejong marked this pull request as draft August 20, 2024 14:46
@Kasdejong Kasdejong marked this pull request as ready for review August 21, 2024 10:06
@Kasdejong Kasdejong requested a review from mmsmits August 21, 2024 10:06
@mmsmits mmsmits requested review from ewoutkramer and removed request for mmsmits August 22, 2024 14:02
@ewoutkramer
Copy link
Member

I don't think this PR will fox #327 since we're still using ScopedNode's ParentResource which is implemented incorrectly, according to the discussion on that issue (%rootResource is for DomainResources, or otherwise put, only contained will not reset the rootResource to the current resource).

@Kasdejong Kasdejong marked this pull request as draft August 28, 2024 13:56
ewoutkramer
ewoutkramer previously approved these changes Sep 2, 2024
@mmsmits mmsmits marked this pull request as ready for review September 9, 2024 08:20
@mmsmits
Copy link
Member

mmsmits commented Sep 10, 2024

This will build once the new SDK package has been released

@mmsmits mmsmits merged commit d77a9de into develop Sep 12, 2024
2 checks passed
@mmsmits mmsmits deleted the feature/FP-invariant-rootresource-fix branch September 12, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invariant rule ref-1 fails when resource that would succeed normally is inside a Parameters resource
3 participants