-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 32-bit variants for XFERLIST_SRAM_LAYOUT and XFERLIST_EP_INFO #54
base: main
Are you sure you want to change the base?
Add 32-bit variants for XFERLIST_SRAM_LAYOUT and XFERLIST_EP_INFO #54
Conversation
* - ep_info | ||
- `sizeof(entry_point_info)` | ||
- hdr_size | ||
- Holds a single `entry_point_info` structure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This structure should be defined here, so please copy over the info from wherever it is kept.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also missing signed-off-by lines
source/transfer_list.rst
Outdated
- The size of the layout in bytes. | ||
|
||
* - addr | ||
- 0x8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why you need this if you're storing 64-bit addresses like the 64-bit variant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry that's a typo! It should indeed be a 32-bit address.
9f1991c
to
873cc79
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only minor comments
873cc79
to
e5159bc
Compare
The TE type falls in the TF sub-range but was accidently placed in it's own subsection. Ensure that it's rendered accordingly. Signed-off-by: Harrison Mutai <harrison.mutai@arm.com>
Signed-off-by: Harrison Mutai <harrison.mutai@arm.com>
Signed-off-by: Harrison Mutai <harrison.mutai@arm.com>
e5159bc
to
73ed892
Compare
Adds 32-bit versions of the XFERLIST_RW_MEM_LAYOUT and XFERLIST_EP_INFO structures to support booting on 32-bit Arm (aarch32) systems, and corrects the Mbed-TLS heap info heading to fall under the Arm subsection.