Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 32-bit variants for XFERLIST_SRAM_LAYOUT and XFERLIST_EP_INFO #54

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

harrisonmutai-arm
Copy link
Contributor

Adds 32-bit versions of the XFERLIST_RW_MEM_LAYOUT and XFERLIST_EP_INFO structures to support booting on 32-bit Arm (aarch32) systems, and corrects the Mbed-TLS heap info heading to fall under the Arm subsection.

* - ep_info
- `sizeof(entry_point_info)`
- hdr_size
- Holds a single `entry_point_info` structure.
Copy link
Contributor

@sjg20 sjg20 Jan 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This structure should be defined here, so please copy over the info from wherever it is kept.

Copy link
Contributor

@danh-arm danh-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also missing signed-off-by lines

source/transfer_list.rst Outdated Show resolved Hide resolved
- The size of the layout in bytes.

* - addr
- 0x8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why you need this if you're storing 64-bit addresses like the 64-bit variant.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry that's a typo! It should indeed be a 32-bit address.

danh-arm
danh-arm previously approved these changes Jan 21, 2025
Copy link
Contributor

@danh-arm danh-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only minor comments

source/transfer_list.rst Outdated Show resolved Hide resolved
source/transfer_list.rst Outdated Show resolved Hide resolved
The TE type falls in the TF sub-range but was accidently placed in it's
own subsection. Ensure that it's rendered accordingly.

Signed-off-by: Harrison Mutai <harrison.mutai@arm.com>
Signed-off-by: Harrison Mutai <harrison.mutai@arm.com>
Signed-off-by: Harrison Mutai <harrison.mutai@arm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants