Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove error-prone (and therefore nullaway) #12

Merged
merged 1 commit into from
Oct 22, 2021
Merged

remove error-prone (and therefore nullaway) #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 1 addition & 16 deletions build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,5 @@
import net.ltgt.gradle.errorprone.CheckSeverity
import net.ltgt.gradle.errorprone.errorprone

plugins {
application
id("net.ltgt.errorprone") version "2.0.2"
}

group = "com.github.firmwehr"
Expand Down Expand Up @@ -67,12 +63,7 @@ dependencies {
implementation("org.apache.logging.log4j:log4j-slf4j-impl:$log4j2")
implementation("com.djdch.log4j:log4j-staticshutdown:1.1.0") // https://stackoverflow.com/a/28835409/1834100

// nullaway + errorprone + annotations
annotationProcessor("com.uber.nullaway", "nullaway", "0.9.2")
// Current pre-release at the time of adding error-prone
errorprone("com.google.errorprone", "error_prone_core", "HEAD-20211020.202200-314")
// The annotations do not have pre-release jars, apparently. Add the released ones
errorprone("com.google.errorprone", "error_prone_annotations", "2.9.0")
// annotations
compileOnly("org.jetbrains", "annotations", "22.0.0")

// commons stuff
Expand All @@ -95,12 +86,6 @@ dependencies {
tasks.withType<JavaCompile> {
options.encoding = "UTF-8"
options.compilerArgs.add("--enable-preview")
if (!name.toLowerCase().contains("test")) {
options.errorprone.apply {
check("NullAway", CheckSeverity.ERROR)
option("NullAway:AnnotatedPackages", "com.github.firmwehr.gentle")
}
}
}

tasks.getByName<Test>("test") {
Expand Down