Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clock sends stop signal when timer reaches zero #15

Open
kmeesters opened this issue Jul 27, 2016 · 3 comments
Open

clock sends stop signal when timer reaches zero #15

kmeesters opened this issue Jul 27, 2016 · 3 comments
Assignees

Comments

@kmeesters
Copy link
Member

The clock changes (visually) to a stop state when it reaches zero. This could also be posted on the message bus so other applications know the time has run out. For example for lights or displaysystems.

@rikkertkoppes
Copy link
Member

We can easily add that. However, it creates the school example of a race condition when there are multiple clock instance.

You'd need an additional effort on the receiving side to handle that properly.

@kmeesters
Copy link
Member Author

Yes, perhaps we could implement something along the lines of what we discussed for scoring? There would be clock 'master' who holds the actual countdown time and send a stop signal. This would also prevent other client on the message bus to accidentally start / reset / arm the clock? This could be also only a rule when a clock has been running (ie. start signal send from a certain node, can only be stopped by that node, or overriden (confirmation)

@rikkertkoppes
Copy link
Member

I'd rather see a rp approach. Combine the streams, pass the result on

idanstark42 added a commit that referenced this issue Jun 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants