Feat/configure amount of matches #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d based on the settings
idanstark42
requested changes
Dec 2, 2018
client/app/pages/tournament-settings/tournament-settings.component.html
Outdated
Show resolved
Hide resolved
alanggreen
requested changes
Dec 2, 2018
client/app/pages/tournament-settings/tournament-settings.component.html
Outdated
Show resolved
Hide resolved
client/app/pages/tournament-settings/tournament-settings.component.html
Outdated
Show resolved
Hide resolved
client/app/pages/tournament-settings/tournament-settings.component.html
Outdated
Show resolved
Hide resolved
client/app/pages/tournament-settings/tournament-settings.component.ts
Outdated
Show resolved
Hide resolved
client/app/pages/tournament-settings/tournament-settings.component.ts
Outdated
Show resolved
Hide resolved
alanggreen
requested changes
Dec 4, 2018
There was a problem hiding this comment.
Wrote this last night but I see I didn't send it
Nice work here. Some requirements not were incomplete.
Main problem is that even though database has the new values, in my test, scoring still shows 1 and 3 rounds.
I added log in router.get('/:team/matches' and it's not called.
idanstark42
approved these changes
Dec 7, 2018
alanggreen
reviewed
Dec 15, 2018
alanggreen
reviewed
Dec 15, 2018
client/app/pages/tournament-settings/tournament-settings.component.ts
Outdated
Show resolved
Hide resolved
alanggreen
approved these changes
Dec 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.