Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Controls still work when a probe loses signal #38

Open
Fedex75 opened this issue Dec 15, 2023 · 3 comments
Open

Controls still work when a probe loses signal #38

Fedex75 opened this issue Dec 15, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@Fedex75
Copy link

Fedex75 commented Dec 15, 2023

When a probe loses CommNet connection the monitors and controls still work.

KSP.log

Steps to reproduce the behavior:

  1. Launch a probe
  2. The probe loses signal
  3. Go into probe control room
  4. Monitors still display information and controls still work

Expected behaviour: The monitors should turn off and controls shouldn't work, like when the probe runs out of electric charge.

image
Here we can see that the probe has no connection but the monitors are still working.

  • OS: Windows 10
@Fedex75 Fedex75 added the bug Something isn't working label Dec 15, 2023
@Fedex75
Copy link
Author

Fedex75 commented Dec 16, 2023

Ok after looking at RasterPropMonitor.cs i think i understand it's more complex. So in order for the computer to disable the monitors when it loses signal, they would have to be configured with "needsCommConnection = true". The ALCORMFDs don't set that field so it's left false. But we can't change that directly on their cfg files because then all MFDs would require signal, even those inside command modules.

So the question then becomes, is there a way to change a field for an individual MFD?

@JonnyOThan
Copy link
Collaborator

Yeah good question...My hunch is that the solution here would be to have some variable on the RasterPropMonitorComputer (the partmodule that lives on the probe part) that controls the behavior. Then all probes can be set up so that they require a signal and command pods don't.

@Fedex75
Copy link
Author

Fedex75 commented Dec 18, 2023

Yeah that sounds good. On my local install i created new MFD props with their needsCommConnection always set to true and used those on the mission control cfg but that solution sucks.

By the way, this is unrelated but would it be possible to show the navigation marker on the MFD's navball?
I mean things like this:
image

Since it already shows markers for prograde and things like that i figure it shouldn't be too hard right? It doesn't necessarily have to show the specific icons like the thermometer, just any symbol would be ok.

@JonnyOThan JonnyOThan transferred this issue from FirstPersonKSP/RasterPropMonitor Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants