fix: honor --no-validate and ignore metadata during archive validation #190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes validation incorrectly checking metadata lines instead of requirement text. The extractRequirementText() function was returning the first non-empty line after the requirement header, which was often metadata like **ID**: REQ-001 instead of the actual requirement statement. Changes: - Updated extractRequirementText() to skip lines matching **Key**: Value pattern - Skip blank lines between header and requirement text - Return first substantive text line for SHALL/MUST validation Added comprehensive tests for: - Requirements with metadata before SHALL/MUST text - Requirements with SHALL in text but not header - Requirements correctly failing without SHALL/MUST - Requirements without metadata fields All 20 validation tests pass. Fixes #159
TabishB
changed the title
This was referenced Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Root Cause
**ID**: ...was the first non-empty line, so validation looked at metadata instead of requirement text.--no-validatetooptions.validate = false, but the archive command only checkednoValidate, so validation still executed.Changes
noValidateandvalidate: falseas skip signals and guard downstream validation calls.Tests