-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix darkmode in Brave Search & Searx #19
Conversation
Sevichecc
commented
Jun 3, 2023
•
edited
Loading
edited
- Fixed the automatic dark mode in Brave Search & Searx.
- Fixed The dark mode CSS selector is not working properly in Brave Search.
- Remove useless text.
Thank you @Sevichecc I really appreciate you working on this and taking the trouble of porting it from your miniflux-fork to my repo. Since you seem to be actively working on it, can you @ me here when the PR is ready for review? |
@Fivefold, This PR seems ready for review. Would you mind taking a look? And I really like the linkding-injector project. Having little experience developing browser extensions, I’ve learned a great deal from your work. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately automatic theme detection still doesn't work fully in Brave and SearXNG. When having a dark system theme and having everything on auto the injection box is light (at least for me on windows 10 and Firefox, although I suspect the same happens with chrome. At least it did before this PR).
A table illustrating the states would look something like this (horizontal is Search engine theme, vertical is extension theme)
System | Light | Dark | |
---|---|---|---|
Auto | ❌ | ✅ | ✅ |
Light | ✅ | ✅ | ✅ |
Dark | ✅ | ✅ | ✅ |
Steps to reproduce:
- Set your OS System theme to dark.
- Set the theme in the search engine to "System" (with Brave) or "Auto" (with SearX)
- Set the relevant themes in the extension settings to "auto"
- Check theme of injection box, it should be light
Can you check if you can reproduce this with a dark system theme?
That's strange. Everything works fine on my computer and browsers. Perhaps there's an issue with the Windows dark mode? My OS and browser versions are: The color mode automatically switches between dark and light mode as follows: 2023-06-04.9.51.00.mov2023-06-04.9.50.01.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, the joys of cross-OS differences. See my other comment regarding options.svelte.
Otherwise I'm happy to merge this. Thank you again for your time and work
This reverts commit 1350700.