Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix darkmode in Brave Search & Searx #19

Merged
merged 10 commits into from
Jun 4, 2023
Merged

Fix darkmode in Brave Search & Searx #19

merged 10 commits into from
Jun 4, 2023

Conversation

Sevichecc
Copy link
Contributor

@Sevichecc Sevichecc commented Jun 3, 2023

  • Fixed the automatic dark mode in Brave Search & Searx.
  • Fixed The dark mode CSS selector is not working properly in Brave Search.
  • Remove useless text.

@Sevichecc Sevichecc changed the title Fix darkmode in Brave Search Fix darkmode in Brave Search & Searx Jun 3, 2023
@Fivefold
Copy link
Owner

Fivefold commented Jun 3, 2023

Thank you @Sevichecc I really appreciate you working on this and taking the trouble of porting it from your miniflux-fork to my repo. Since you seem to be actively working on it, can you @ me here when the PR is ready for review?

@Sevichecc
Copy link
Contributor Author

@Fivefold, This PR seems ready for review. Would you mind taking a look?

And I really like the linkding-injector project. Having little experience developing browser extensions, I’ve learned a great deal from your work. Thank you!

Copy link
Owner

@Fivefold Fivefold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately automatic theme detection still doesn't work fully in Brave and SearXNG. When having a dark system theme and having everything on auto the injection box is light (at least for me on windows 10 and Firefox, although I suspect the same happens with chrome. At least it did before this PR).

A table illustrating the states would look something like this (horizontal is Search engine theme, vertical is extension theme)

System Light Dark
Auto
Light
Dark

Steps to reproduce:

  1. Set your OS System theme to dark.
  2. Set the theme in the search engine to "System" (with Brave) or "Auto" (with SearX)
  3. Set the relevant themes in the extension settings to "auto"
  4. Check theme of injection box, it should be light

Can you check if you can reproduce this with a dark system theme?

@Sevichecc
Copy link
Contributor Author

That's strange. Everything works fine on my computer and browsers. Perhaps there's an issue with the Windows dark mode?

My OS and browser versions are:
• OS: macOS Ventura 13.5
• Brave Browser: v1.52.117
• Firefox: v112.0.1 (64-bit)
• Chrome: v114.0.5735.90

The color mode automatically switches between dark and light mode as follows:

2023-06-04.9.51.00.mov
2023-06-04.9.50.01.mov

src/options.svelte Outdated Show resolved Hide resolved
Copy link
Owner

@Fivefold Fivefold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, the joys of cross-OS differences. See my other comment regarding options.svelte.

Otherwise I'm happy to merge this. Thank you again for your time and work

@Fivefold Fivefold merged commit 0ab847d into Fivefold:master Jun 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants