Implement Get Element Attribute.

[grokys]

Implements /session/{session id}/element/{element id}/attribute/{name}.

Not so crazy about using reflection here, but it seems it's the only way to get the property ID from a string?

Fixes #25

TODO

• Add test
• Make test pass
• Add support for Pattern.Property attributes as supported by WinAppDriver (e.g. https://github.com/microsoft/WinAppDriver/blob/master/Tests/WebDriverAPI/ElementAttribute.cs#L69)

[grokys]

The test for this feature is currently failing, even though in another scenario it works fine. I think (but I'm not sure) that it's because it's using Selenium.WebDriver whereas the other scenario is using Appium.WebDriver. Selenium.WebDriver seems to be trying to run a script to get attributes?

[grokys]

Yep, confirmed that the problem is the Selenium.WebDriver package. Changing to use <PackageReference Include="Appium.WebDriver" Version="5.0.0-rc.8" /> allows the tests to run.

[aristotelos]

Yep, confirmed that the problem is the Selenium.WebDriver package. Changing to use <PackageReference Include="Appium.WebDriver" Version="5.0.0-rc.8" /> allows the tests to run.

I did a quick test, GetAttribute indeed converts to a script. But you can use GetDomAttribute instead which maps to the attribute API.

I am OK converting the tests to use Appium.WebDriver, but I think keeping the freedom to use Selenium.WebDriver as a user is also good. Can we document both options in the README? I.e. we should document that Selenium.WebDriver's GetAttribute is not supported but GetDomAttribute is. (I am also still wondering if there is a Selenium option to use the attribute API when calling GetAttribute.)

[aristotelos]

Can we add a little explanation to the README about attributes and properties and their difference (if there is any)? Adding it to the WebDriver interpretation section would make sense to me. @Roemer Do you have suggestions of attribute vs. property interpretation, is there a difference or are they the same for Windows UI automation elements?

Is there a documentation from Microsoft on which attributes are supported on Windows UI automation elements? If so, it would be good to refer to it in the README.

[grokys]

I did a quick test, GetAttribute indeed converts to a script. But you can use GetDomAttribute instead which maps to the attribute API.

Ah! Yes that works! Ok then I think #28 is unnecessary for the moment then. I've pushed a change to the test to use GetDomAttribute.

[grokys]

Added support for pattern properties. I think this PR should be ready for review now.

Can we add a little explanation to the README about attributes and properties and their difference (if there is any)? Adding it to the WebDriver interpretation section would make sense to me

Sure, though I'm not sure I'm the right person to write that ;) From what I understand in WinAppDriver, attributes simply map to UIA element properties and pattern properties if they're in the form Pattern.Property. If it really is that simple I'm happy to update the readme.

Is there a documentation from Microsoft on which attributes are supported on Windows UI automation elements? If so, it would be good to refer to it in the README.

I'm not sure there is... I can't remember where I found out about it but I assume it was StackOverflow.

[aristotelos]

@Roemer Is this the right link to reference for UIA3 automation element properties? https://learn.microsoft.com/en-us/windows/win32/winauto/uiauto-automation-element-propids

[grokys]

@aristotelos you didn't ask me, but I believe that is the correct link for the UAI3 properties, yes.

[aristotelos]

@grokys Created grokys#1 for updating the documentation a little.

Could you also look into the build warnings generated about using nullable reference types?

[aristotelos]

Fix the build check warnings: "The annotation for nullable reference types should only be used in code within a '#nullable' annotations context."

[grokys]

Fix the build check warnings: "The annotation for nullable reference types should only be used in code within a '#nullable' annotations context."

Fixed. Any reason the tests aren't using nullable?

[aristotelos]

Fix the build check warnings: "The annotation for nullable reference types should only be used in code within a '#nullable' annotations context."

Fixed. Any reason the tests aren't using nullable?

No, no good reason, so a PR to change that is welcome.

[aristotelos]

@grokys Could you still merge grokys#1 into your branch so that the documentation is more complete?

[grokys]

@aristotelos grokys#1 merged, thanks for doing that!

EDIT: Also added some docs about how attributes map to UIA properties.

[aristotelos]

Approved with one minor test naming suggestion

[grokys]

Thanks, applied!