Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support origin property in actions. #29

Merged
merged 2 commits into from
May 2, 2024

Conversation

grokys
Copy link
Contributor

@grokys grokys commented May 1, 2024

This allows Actions.MoveToElement() and Actions.MoveByOffset to work.

Added a pair of failing tests, and then a commit which fixes them.

https://www.w3.org/TR/webdriver2/#dfn-get-coordinates-relative-to-an-origin

Referenced https://github.com/appium/appium-uiautomator2-server/blob/master/app/src/main/java/io/appium/uiautomator2/utils/w3c/ActionsTokenizer.java#L307 for implementation

Copy link
Collaborator

@aristotelos aristotelos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for the contribution!

@aristotelos aristotelos merged commit d5fc010 into FlaUI:main May 2, 2024
3 checks passed
@grokys grokys deleted the fixes/actions-move-origin branch May 2, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants