Make Get Element Text match WinAppDriver more closely. #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some are failing. To test this effectively, list controls really need a selection, so edited the test application to give a default selection.
grokys
commented
May 2, 2024
| [Test] | ||
| public void GetText_Label_ReturnsRenderedText() | ||
| [TestCase("TextBox", "Test TextBox")] | ||
| [TestCase("PasswordBox", "●●●●●●●●●●")] |
There was a problem hiding this comment.
This differs from WinAppDriver in that there a ???????? string is returned, however I feel that the existing behavior of returning ● characters is less ambiguous so I left it.
aristotelos
approved these changes
May 2, 2024
|
|
||
| Assert.That(text, Is.EqualTo("Test TextBox")); | ||
|
|
||
| // Seems that the order in which the selected items are returned is not guaranteed. |
There was a problem hiding this comment.
Maybe this is a FlaUI issue to report?
There was a problem hiding this comment.
It could be but given that we're essentially just calling the COM pattern, I suspect it's what WPF is actually returning? WinAppDriver from what I can see though doesn't have this issue, but I'm not sure whether they're normalizing the selection themselves or not. Regardless, didn't feel like a big enough issue for now to spend much time investigating, got quite a few other PRs incoming ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.w3.org/TR/webdriver2/#get-element-text says about this:
Because it's implementation-defined, FlaUI.WebDriver's currently behavior is technically correct, however I feel the behavior from WinAppDriver is more useful. This PR tries to emulate that behavior by looking for various implemented patterns and using those to get the text value.
Tested against WinAppDriver's behavior and seems to match so far, with one exception noted in the comments.