On session close, don't close apps that weren't started by the WebDriver #31
Conversation
Tests currently failing.
When a session times out, don't close the app if the session was attached to an existing app using `appTopLevelWindow` or `appTopLevelWindowTitleMatch`.
|
Is this exposing the same behavior as other drivers, e.g. appium-windows-driver? The specification is not completely clear about what is best, see https://www.w3.org/TR/webdriver2/#dfn-close-the-session |
Hmm, as far as I remember, WinAppDriver doesn't have a "close app on timeout" feature; I don't know if Edit: I have the "timeout" part in my head because that's where I kept encountering this - I'd stop a test that I was debugging mid-run, the session would time out and the process I was debugging would exit. But it's not just on timeout that the app is being closed, it's when the session ends in general, so ignore the timeout part above ;) |
|
Just checked |
When a session finishes or times out, don't close the app if the session was attached to an existing app using
appTopLevelWindoworappTopLevelWindowTitleMatch.This feels like intuitive behavior to me: the app was running before the session started so one can assume that the user is in control of the app lifetime.
Added a commit with failing tests, and a commit with a simple fix.