On session close, don't close apps that weren't started by the WebDriver #31
+45
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a session finishes or times out, don't close the app if the session was attached to an existing app using
appTopLevelWindow
orappTopLevelWindowTitleMatch
.This feels like intuitive behavior to me: the app was running before the session started so one can assume that the user is in control of the app lifetime.
Added a commit with failing tests, and a commit with a simple fix.