Reinstate usage of GetAllTopLevelWindows. #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was removed due to FlaUI/FlaUI#596, which I would like to investigate, however I've so far been unable to repro the issue. Maybe if the failing code path is enabled then I'll hit it and will be able to investigate. Also, I need to be able to retrieve all open window handles, so only returning the main window and modal windows is a problem for me...
aristotelos
requested changes
May 8, 2024
aristotelos
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure what you'll think about this one but this PR reinstates the use of
GetAllTopLevelWindows. This was removed due to FlaUI/FlaUI#596, which I would like to investigate, however I've so far been unable to repro the issue. Maybe if the failing code path is enabled then I'll hit it and will be able to investigate.Also, I need to be able to retrieve all open window handles, so only returning the main window and modal windows is a problem for me...