Add input sources in GetOrCreateInputSource #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The spec is unclear on when input sources should be added to the input source map. Previously it was being done in `ExtractActionSequence` but the problem with doing it there is that there's no way to know if `GetOrCreateInputSource` is returning an existing input source or creating a new one, causing FlaUI#43. Move the logic to add an input source to `GetOrCreateInputSource` to fix this. (It would kinda make sense to do it instead in `CreateInputSource` but the spec defines a caller of this method which adds the input source manually :/ ) Fixes FlaUI#43
aristotelos
approved these changes
May 14, 2024
|
Would it be possible to add a test that verifies the fix? |
|
For now, I'll merge it, unit or integration tests can be added later. |
|
Thanks @aristotelos ! Sorry I've not had time to create a test yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The spec is unclear on when input sources should be added to the input source map. Previously it was being done in
ExtractActionSequencebut the problem with doing it there is that there's no way to know ifGetOrCreateInputSourceis returning an existing input source or creating a new one, causing #43.Move the logic to add an input source to
GetOrCreateInputSourceto fix this.(It would kinda make sense to do it instead in
CreateInputSourcebut the spec defines callers of this method which add the input source manually :/ )Fixes #43