[Operator] Fix embedding op backward with bf16 #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tongxin
reviewed
Nov 22, 2024
| @@ -70,11 +70,15 @@ def embedding_backward_kernel( | |||
| if not HAS_PADDING_IDX: | |||
| grad_in += row_idx * N | |||
| embedding_grad = tl.load(grad_out + cols, mask, other=0.0) | |||
| if tl.constexpr(embedding_grad.dtype.is_bf16()): | |||
| embedding_grad = embedding_grad.to(tl.float32) | |||
| tl.atomic_add(grad_in + cols, embedding_grad, mask=mask) | |||
There was a problem hiding this comment.
Atomically updating gradients from a massive number of ctas may be a problem. Could we reduce contention with local updates in a gsl style kernel?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
Operator
Type of Change
Bug Fix
Description
Fix embedding op backward with bf16. Before atomic_add(bf16), we convert both ptr and data to fp32.
Issue
Progress
Performance