Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add iluvatar bert case. #56

Merged
merged 8 commits into from
May 31, 2023
Merged

add iluvatar bert case. #56

merged 8 commits into from
May 31, 2023

Conversation

forestlee95
Copy link
Contributor

  1. add iluvatar bert case.
  2. merge bert benchmark hox fix.
    iluvatar_bert.zip

@yuzhou03
Copy link
Contributor

yuzhou03 commented Apr 12, 2023 •
edited
Loading

根据厂商适配的文档，应提供readme文件，说明在BI-V100上的已经获得的运行数据。其他配置的运行数据，可以等资源到位后补充上。

@upvenly upvenly self-requested a review April 17, 2023 03:56
@upvenly upvenly self-assigned this Apr 17, 2023
@upvenly upvenly removed their request for review April 20, 2023 08:51
@upvenly upvenly removed their assignment Apr 20, 2023
@forestlee95
Copy link
Contributor Author

run_bert_1X8_iluvatar.zip
run_bert_1X1_iluvatar.zip
BI-V100 单卡和8卡日志。

@yuzhou03 yuzhou03 requested a review from upvenly May 10, 2023 08:15
@yuzhou03 yuzhou03 assigned upvenly and Ox7c000000 and unassigned upvenly May 10, 2023
upvenly
upvenly reviewed May 23, 2023
View reviewed changes
training/benchmarks/bert/pytorch/config/_base.py Outdated Show resolved Hide resolved
training/benchmarks/driver/config_manager.py Outdated
@@ -144,6 +144,7 @@ def activate(base_config,

parsed_params = parse_from_args_and_config(params, cmd_args, ext_config,
enable_extern_config)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

同上

training/iluvatar/bert-pytorch/README.md Show resolved Hide resolved
training/iluvatar/bert-pytorch/config/layers/attention.py
@@ -0,0 +1,81 @@
from torch import nn
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

config 下面不该出现模型结构相关的代码哈，layers/attention.py 路径位置不对

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个layers文件夹也是从nvidia的标准case copy过来的-。-
image

training/iluvatar/bert-pytorch/config/requirements.txt Outdated Show resolved Hide resolved
@shh2000
Copy link
Collaborator

shh2000 commented May 29, 2023

如未使用，请删除iluvatar/bert-pytorch/config/layers相关文件

shh2000
shh2000 reviewed May 29, 2023
View reviewed changes
training/benchmarks/bert/pytorch/config/_base.py Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

请restore此文件，或者修正后面的空行

shh2000
shh2000 reviewed May 29, 2023
View reviewed changes
training/benchmarks/driver/config_manager.py Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

请restore或修正空行

@forestlee95
Copy link
Contributor Author

如未使用，请删除iluvatar/bert-pytorch/config/layers相关文件

该文件夹删除后运行会报错，应该不能删除。

@upvenly upvenly merged commit 4151af8 into FlagOpen:main May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuzhou03 yuzhou03 yuzhou03 approved these changes

@upvenly upvenly upvenly approved these changes

@shh2000 shh2000 shh2000 approved these changes

Assignees

@upvenly upvenly

@Ox7c000000 Ox7c000000

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@forestlee95 @yuzhou03 @shh2000 @upvenly @Ox7c000000