squash! minor

client_test.go

@@ -560,7 +560,7 @@ func TestOfflineMode(t *testing.T) {
 	assert.Equal(t, fixtures.Feature1ID, allFlags[0].FeatureID)
 	assert.Equal(t, fixtures.Feature1Value, allFlags[0].Value)
 
-	// And GetIdentityFlags should work as well
+	// And GetIdentityFlags works as well
 	flags, err = client.GetIdentityFlags(ctx, "test_identity", nil)
 	assert.NoError(t, err)
 
@@ -587,6 +587,7 @@ func TestOfflineHandlerIsUsedWhenRequestFails(t *testing.T) {
 	}))
 	defer server.Close()
 
+	// When
 	client := flagsmith.NewClient(fixtures.EnvironmentAPIKey, flagsmith.WithOfflineHandler(offlineHandler),
 		flagsmith.WithBaseURL(server.URL+"/api/v1/"))
 
@@ -601,4 +602,17 @@ func TestOfflineHandlerIsUsedWhenRequestFails(t *testing.T) {
 	assert.Equal(t, fixtures.Feature1Name, allFlags[0].FeatureName)
 	assert.Equal(t, fixtures.Feature1ID, allFlags[0].FeatureID)
 	assert.Equal(t, fixtures.Feature1Value, allFlags[0].Value)
+
+	// And GetIdentityFlags works as well
+	flags, err = client.GetIdentityFlags(ctx, "test_identity", nil)
+	assert.NoError(t, err)
+
+	allFlags = flags.AllFlags()
+
+	assert.Equal(t, 1, len(allFlags))
+
+	assert.Equal(t, fixtures.Feature1Name, allFlags[0].FeatureName)
+	assert.Equal(t, fixtures.Feature1ID, allFlags[0].FeatureID)
+	assert.Equal(t, fixtures.Feature1Value, allFlags[0].Value)
+
 }

offline_handler.go

@@ -15,6 +15,7 @@ type LocalFileHandler struct {
 	environment *environments.EnvironmentModel
 }
 
+// NewLocalFileHandler creates a new LocalFileHandler with the given path
 func NewLocalFileHandler(environmentDocumentPath string) (*LocalFileHandler, error) {
 	// Read the environment document from the specified path
 	environmentDocument, err := os.ReadFile(environmentDocumentPath)

options.go

@@ -103,11 +103,15 @@ func WithProxy(proxyURL string) Option {
 	}
 }
 
+// WithOfflineHandler returns an Option function that sets the offline handler.
 func WithOfflineHandler(handler OfflineHandler) Option {
 	return func(c *Client) {
 		c.offlineHandler = handler
 	}
 }
+
+// WithOfflineMode returns an Option function that enables the offline mode.
+// NOTE: before using this option, you should set the offline handler.
 func WithOfflineMode() Option {
 	return func(c *Client) {
 		c.config.offlineMode = true