Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force content type in API requests #100

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

matevzmihalic
Copy link
Contributor

Fixes #94

Previously UpdateEnvironment function didn't fail with error If base URL was set to <flagsmith address> instead of <flagsmith address>/api/v1/, because a request to c.config.baseURL + "environment-document/" redirected to login page without error.

Resty client then unmarshalled HTML page into empty EnvironmentModel and accessing pointers in that struct later caused panics.

@gagantrivedi gagantrivedi merged commit 48c37cf into Flagsmith:main Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flagsmith panics with wrong Base URL set
2 participants