Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track all feature flag calls #81

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JonasAlfredsson
Copy link
Contributor

If an analytics processor exists we previouly only tracked feature flag names that were present either from the environment or from the API. However, this gave us no information about calls to flags that either were wrong, or were handled by the default handler.

With this change we now track all calls for more extensive coverage.

If an analytics processor exists we previouly only tracked feature
flag names that were present either from the environment or from the
API. However, this gave us no information about calls to flags that
either were wrong, or were handled by the default handler.

With this change we now track all calls for more extensive coverage.
@matthewelwell
Copy link
Contributor

Hey @JonasAlfredsson, this is interesting. I can definitely understand the use case, however, I'm not sure how useful it would be right now since there is no functionality for surfacing this data, right? What was your intention here?

@matthewelwell matthewelwell self-assigned this May 30, 2023
@JonasAlfredsson
Copy link
Contributor Author

My intention is to make tracking more accurate by also recording every time we call for a feature flag that is subsequently handled by the default handler instead of only when we get them via the API/Environment.

If there is no way of seeing the calls to "invalid" feature names, then perhaps that is another feature request that should be placed on the server issue tracker (if there is such a one)?.

@matthewelwell
Copy link
Contributor

Yep, for sure. We track all of our server feature requests / issues here: https://github.com/Flagsmith/flagsmith/issues

@JonasAlfredsson
Copy link
Contributor Author

Added a feature request there, where it could be discussed at a higher level if desired.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants