Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support transient identities and traits #56

Merged
merged 22 commits into from
Oct 10, 2024

Conversation

matthewelwell
Copy link
Contributor

@matthewelwell matthewelwell commented Oct 4, 2024

This PR supersedes #54 and apples all of the fixes for the comments made on that PR.

Note that as part of this PR, I have started to use more functionality of the mockServer class in the tests. I would love to move all of the tests eventually to use when(...).respond(...) but that was out of the scope of this PR. This PR focuses solely on implementing the transient attribute where necessary and writing it's own tests.

@matthewelwell matthewelwell marked this pull request as ready for review October 4, 2024 17:04
@matthewelwell matthewelwell requested a review from khvn26 October 4, 2024 17:04
@khvn26
Copy link
Member

khvn26 commented Oct 4, 2024

Closes #52

Copy link
Member

@khvn26 khvn26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@khvn26 khvn26 merged commit 1604ed0 into main Oct 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants