Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support transient identities and traits #66

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

khvn26
Copy link
Member

@khvn26 khvn26 commented Aug 27, 2024

Closes #63.

  • Add optional transient argument to get_identity_flags
  • Add support for trait configuration values with optional transient key
  • Remove unneeded default argument values from private methods
  • Remove unneeded comments from the spec

Notes:

  1. I've added a rubocop:disable Style/OptionalBooleanParameter exclusion for the new argument to get_identity_flags. This is to avoid conflict in case a user intends to send a trait called transient.
  2. I've removed commented out specs for set_trait/get_traits interfaces that have not been implemented. I don't like having commented out code in general, and those methods are not expected to be there in a server-side SDK anyway.
  3. I've removed the default traits = {} from internal methods as they are not needed — the empty hash is always provided by the top get_identity_flags interface — but also because Rubocop complained about having non-optional transient argument after traits, and I did not want to change the argument order anywhere, or litter the default value for transient throughout the stack.

- Add optional `transient` argument to `get_identity_flags`
- Add support for trait configuration values with optional `transient` key
- Remove unneeded default argument values from private methods
- Remove unneeded comments from the spec
@khvn26 khvn26 merged commit 046644f into main Aug 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support transient identities and traits
2 participants