fix: feature segments created with priority 0 are sent to bottom #4383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
Docker builds report
|
|
Uffizzi Preview |
matthewelwell
changed the title
…rating on current segment
matthewelwell
force-pushed
the
fix/handle-more-scenarios-for-priority-setting
branch
from
917ded1 to
3f1fb19
Compare
khvn26
reviewed
Jul 24, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4383 +/- ##
=======================================
Coverage 96.82% 96.83%
=======================================
Files 1165 1165
Lines 38568 38621 +53
=======================================
+ Hits 37345 37398 +53
Misses 1223 1223 ☔ View full report in Codecov by Sentry. |
khvn26
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The previous PR here actually causes an issue because the FE always defaults to sending the priority as 0.
This PR is in part accounting for that, but also accounting for the fact that the
django-ordered-modellibrary that we are using doesn't enforce uniqueness on the priority so, when the priority is set in the save, any subsequent calls toto()don't work because it early returns that it already exists at that priority. The issue is that we now likely have 2 feature segments at that priority. To resolve this, we first move the 'collision' feature segment down and out of the way before completing the save.How did you test this code?
Added a bunch more tests for all scenarios.