fix: add logic to set segment to lowest priority if not set #4381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
Docker builds report
|
|
Uffizzi Preview |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4381 +/- ##
=======================================
Coverage 96.82% 96.82%
=======================================
Files 1165 1165
Lines 38561 38568 +7
=======================================
+ Hits 37338 37345 +7
Misses 1223 1223 ☔ View full report in Codecov by Sentry. |
khvn26
approved these changes
Jul 24, 2024
matthewelwell
deleted the
fix/versioning-change-request-feature-segment-priority
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fix behaviour when creating a segment override to add the segment override as the lowest (i.e.. biggest number) priority when a specific priority is not provided.
The specific use case for this is to ensure that, when 2 separate change requests are created on a new feature to add 2 different segment overrides, the second one that gets published, correctly has the priority set, and doesn't conflict with the first one.
How did you test this code?
Added a new unit test.