-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce the SDK Evaluation Context object #4413
Comments
My preference for the implementation is (1) as I am keen to get transient traits out there ASAP. It also gives us some time to perfect the implementation and, if we decide it's not quite right, we would only need a breaking change in a single SDK. The only concern here would be that the documentation becomes slightly more difficult, but I think we can get around that. |
A few comments on the schema:
|
I mirror @matthewelwell's comments on the approach. But other than that the overall approach seems sensible to me. |
Added the one outstanding comment to the PR |
Abstract
While implementing #4278, a discussion has occurred about how we should approach SDK changes in the future.
The consensus is we should take after OpenFeature and implement a common evaluation context object that a single
getFlags
interface should accept as its only input.I'm creating this issue as a hub for further implementation discussion and planning.
Schema proposal
You can observe and review the proposed schema in #4414.
Implementation plan
For implementation phase 1, We should settle on one of the following:
For phase 2, we should consider a single
/api/v2/flags
API with a schema identical to the Evaluation Context schema. Should we go forward with this, it'll allow us to fully code generate remote evaluation parts of the SDKs!The text was updated successfully, but these errors were encountered: