You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following is a proposed Flagsmith Evaluation Context schema JSON Schema definition.
Notes
IdentityEvaluationContext.traits is a mapping of trait keys to a TraitEvaluationContext | null union. In case a null is provided, we assume intent to delete the previously persisted trait.
TraitEvaluationContext.value can only be a string now.
We now have a TraitEvaluationContext.type enum field designating the trait value type. For now it will support an SDK-side mapping layer. It's expected that the v2 SDK API should support it in the future.
How did you test this code?
This is a documentation change, but I'm verifying the schema against a validator.
@khvn26 I love the idea of a schema.
I would like to see examples of how this schema would be used. While I think the current schema is complete and clear, I think we could simplify the structure of some of the contexts, but that would be clearer if we could have some implementation examples of the schema.
@novakzaballa One thing I could do to demonstrate is to go ahead and add it for JS and Golang SDK transient ids/traits PRs. You'll be able to review the schema with those implementations in consideration.
@novakzaballa One thing I could do to demonstrate is to go ahead and add it for JS and Golang SDK transient ids/traits PRs. You'll be able to review the schema with those implementations in consideration.
Let's do that @khvn26 . Some examples I generated look good to me and we can always optimize if we see an opportunity while we move forward. I'll approve the PR. Nice job!
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
github-actions
bot
added
feature
khvn26
force-pushed
the
feat/evaluation-context-schema
branch
from
Thanks for submitting a PR! Please check the boxes below:
Contributes to #4413.
docs/if required so people know about the feature!Changes
The following is a proposed Flagsmith Evaluation Context schema JSON Schema definition.
Notes
IdentityEvaluationContext.traitsis a mapping of trait keys to aTraitEvaluationContext | nullunion. In case anullis provided, we assume intent to delete the previously persisted trait.TraitEvaluationContext.valuecan only be astringnow.TraitEvaluationContext.typeenum field designating the trait value type. For now it will support an SDK-side mapping layer. It's expected that the v2 SDK API should support it in the future.How did you test this code?
This is a documentation change, but I'm verifying the schema against a validator.