fix: don't allow bypassing ALLOW_REGISTRATION_WITHOUT_INVITE behaviour
#4454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
|
Uffizzi Preview |
matthewelwell
changed the title
ALLOW_REGISTRATION_WITHOUT_INVITE behaviourALLOW_REGISTRATION_WITHOUT_INVITE behaviour
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4454 +/- ##
=======================================
Coverage 96.85% 96.86%
=======================================
Files 1170 1172 +2
Lines 38812 38896 +84
=======================================
+ Hits 37592 37676 +84
Misses 1220 1220 ☔ View full report in Codecov by Sentry. |
Docker builds report
|
|
FE component has been merged and tested here |
khvn26
reviewed
Aug 7, 2024
khvn26
reviewed
Aug 7, 2024
khvn26
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR adds a new
invite_hashfield to the payload on the register endpoint to ensure that it's not possible to bypass theALLOW_REGISTRATION_WITHOUT_INVITEsetting.Note: this will need to be added on the frontend. It's likely that the E2E tests will fail until that is done.
How did you test this code?
Added new tests and updated an existing test.