Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add invite hash to signup endpoints #4458

Merged
merged 1 commit into from
Aug 7, 2024
Merged

chore: Add invite hash to signup endpoints #4458

merged 1 commit into from
Aug 7, 2024

Conversation

kyle-ssg
Copy link
Member

@kyle-ssg kyle-ssg commented Aug 7, 2024 •
edited
Loading

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

  • Sends the invite hash with to the registration/oauth endpoints

@kyle-ssg kyle-ssg requested a review from a team as a code owner August 7, 2024 09:16
@kyle-ssg kyle-ssg requested review from novakzaballa and removed request for a team August 7, 2024 09:16
@vercel Vercel
Copy link

vercel bot commented Aug 7, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 7, 2024 9:17am
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 7, 2024 9:17am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Aug 7, 2024 9:17am

@github-actions github-actions bot added front-end Issue related to the React Front End Dashboard chore labels Aug 7, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 7, 2024 •
edited
Loading

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-4458 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-4458 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-4458 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith:pr-4458 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4458 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-frontend:pr-4458 Finished ✅ Results ✅

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 7, 2024 •
edited
Loading

Uffizzi Preview deployment-55036 was deleted.

matthewelwell
matthewelwell approved these changes Aug 7, 2024
View reviewed changes
Copy link
Contributor

@matthewelwell matthewelwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested this using email and password sign up via the preview urls, but I can't test OAuth until it's deployed to a real environment. I'm approving this and will test in staging.

@matthewelwell matthewelwell added this pull request to the merge queue Aug 7, 2024
Merged via the queue into main with commit fb27b57 Aug 7, 2024
31 checks passed
@matthewelwell matthewelwell deleted the chore/add-signup-invite-hash branch August 7, 2024 09:55
@matthewelwell matthewelwell mentioned this pull request Aug 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewelwell matthewelwell matthewelwell approved these changes

@novakzaballa novakzaballa Awaiting requested review from novakzaballa novakzaballa is a code owner automatically assigned from Flagsmith/flagsmith-front-end

Assignees
No one assigned
Labels
chore front-end Issue related to the React Front End Dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kyle-ssg @matthewelwell