fix: add migration to clean up corrupt data caused by feature versioning #4873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewelwell
requested review from
zachaysan
and removed request for
a team
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
Docker builds report
|
|
Uffizzi Preview |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4873 +/- ##
=======================================
Coverage 97.37% 97.38%
=======================================
Files 1186 1188 +2
Lines 41261 41340 +79
=======================================
+ Hits 40179 40258 +79
Misses 1082 1082 ☔ View full report in Codecov by Sentry. |
gagantrivedi
approved these changes
Nov 29, 2024
matthewelwell
deleted the
fix/add-migration-to-fix-existing-versioning-data-issues
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Related to #4872. This PR adds the migration which retrospectively cleans the data up.
How did you test this code?
We have tested these steps by manually implementing them on current data which was corrupted. I have also written a long and comprehensive migration test to try and (a) illustrate what we're trying to fix, and (b) test that the fix is correct.