Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent enabling versioning from affecting scheduled change requests #4872

Merged
merged 2 commits into from
Nov 28, 2024

Conversation

matthewelwell
Copy link
Contributor

Changes

Fixes an issue where all scheduled feature states are 'stolen' when versioning is enabled in any environment in the platform.

How did you test this code?

Added additional logic to an existing unit test.

Copy link

vercel bot commented Nov 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Nov 28, 2024 1:41pm
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Visit Preview Nov 28, 2024 1:41pm
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Visit Preview Nov 28, 2024 1:41pm

@github-actions github-actions bot added the api Issue related to the REST API label Nov 28, 2024
@github-actions github-actions bot added the fix label Nov 28, 2024
@matthewelwell matthewelwell marked this pull request as ready for review November 28, 2024 13:41
@matthewelwell matthewelwell requested a review from a team as a code owner November 28, 2024 13:41
@matthewelwell matthewelwell requested review from gagantrivedi and removed request for a team November 28, 2024 13:41
@github-actions github-actions bot removed the fix label Nov 28, 2024
@github-actions github-actions bot added the fix label Nov 28, 2024
Copy link
Contributor

github-actions bot commented Nov 28, 2024

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-4872 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-4872 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-4872 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-4872 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4872 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-4872 Finished ✅ Results

Copy link
Contributor

github-actions bot commented Nov 28, 2024

Uffizzi Preview deployment-58656 was deleted.

Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.37%. Comparing base (15cf98f) to head (4436434).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4872   +/-   ##
=======================================
  Coverage   97.37%   97.37%           
=======================================
  Files        1186     1186           
  Lines       41261    41273   +12     
=======================================
+ Hits        40179    40191   +12     
  Misses       1082     1082           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthewelwell matthewelwell merged commit c7aa30b into main Nov 28, 2024
54 checks passed
@matthewelwell matthewelwell deleted the fix/enable-environment-versioning-data-issue branch November 28, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants