-
Notifications
You must be signed in to change notification settings - Fork 401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: prevent enabling versioning from affecting scheduled change requests #4872
Merged
matthewelwell
merged 2 commits into
main
from
fix/enable-environment-versioning-data-issue
Nov 28, 2024
Merged
fix: prevent enabling versioning from affecting scheduled change requests #4872
matthewelwell
merged 2 commits into
main
from
fix/enable-environment-versioning-data-issue
Nov 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
matthewelwell
requested review from
gagantrivedi
and removed request for
a team
November 28, 2024 13:41
Docker builds report
|
gagantrivedi
approved these changes
Nov 28, 2024
Uffizzi Preview |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4872 +/- ##
=======================================
Coverage 97.37% 97.37%
=======================================
Files 1186 1186
Lines 41261 41273 +12
=======================================
+ Hits 40179 40191 +12
Misses 1082 1082 ☔ View full report in Codecov by Sentry. |
matthewelwell
deleted the
fix/enable-environment-versioning-data-issue
branch
November 28, 2024 14:00
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes an issue where all scheduled feature states are 'stolen' when versioning is enabled in any environment in the platform.
How did you test this code?
Added additional logic to an existing unit test.