-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle is_num_identity_overrides_complete
field in the feature list UI
#4931
Comments
tiagoapolo
added a commit
that referenced
this issue
Dec 23, 2024
ref: #4931 Signed-off-by: Tiago Fonseca <tiago@tiagopaiva.me>
tiagoapolo
added a commit
that referenced
this issue
Dec 23, 2024
ref: #4931 Signed-off-by: Tiago Fonseca <tiago@tiagopaiva.me>
4 tasks
On hold until #4840 is merged. |
Testing it |
I tested using 1000+ identity overrides for a feature and I did not succeed to get is_num_identity_overrides_complete as False. Therefore I could not see the + sign being used. cc: @zachaysan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The backend has added a new
is_num_identity_overrides_complete
to each feature when retrieving the list of features for a given project (and when theenvironment
query parameter is provided).If this field is
false
, then the number returned innum_identity_overrides
is not an exact representation of the number of identity overrides, so the FE should concatenate the number with a+
afterwards.The text was updated successfully, but these errors were encountered: