feat: async the logic for cloning feature states into a cloned environment #4005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Uffizzi Ephemeral Environment
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4005 +/- ##
=======================================
Coverage 96.28% 96.28%
=======================================
Files 1143 1144 +1
Lines 36992 37010 +18
=======================================
+ Hits 35618 35636 +18
Misses 1374 1374 ☔ View full report in Codecov by Sentry. |
|
Note that this PR is only marked as draft as we need to discuss with the FE team how to implement the 'pending creation' logic. I don't want to review / merge this PR before then as it includes a migration that might need to change. |
# Conflicts: # api/environments/models.py
matthewelwell
force-pushed
the
feat/async-environment-clone
branch
from
423d264
to
2a662af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
pre-committo check lintingdocs/if required so people know about the feature!Changes
This PR utilises the task processor to handle the cloning of feature states when cloning an environment. This stemmed from work I did to handle the cloning of an environment that is using v2 versioning, however, even the cloning of an environment on the old versioning system is pretty intensive.
This PR also adds a new field
is_creatingto the environment model which can be used by the frontend to determine when an environment has been successfully cloned.Before merging this, we will need to get the FE to use the
is_creatingfield to show some indication that the environment is not yet ready for use.Related issue: #4489
How did you test this code?
Since we're enforcing synchronous running of tasks in the test suite, the existing tests on the
Environment.clonemethod cover the behaviour. I added an extra assertion to a couple of existing tests for the newis_creatingfield that I added to the environment model.