Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add autocomplete for login #4103

Merged
merged 2 commits into from
Jun 4, 2024
Merged

fix: Add autocomplete for login #4103

merged 2 commits into from
Jun 4, 2024

Conversation

kyle-ssg
Copy link
Member

@kyle-ssg kyle-ssg commented Jun 4, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

#3980 turned off autocomplete for all inputs, this PR adds it for login.

How did you test this code?

Please describe.

@vercel Vercel
Copy link

vercel bot commented Jun 4, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 4, 2024 0:35am
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 4, 2024 0:35am
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 4, 2024 0:35am

@kyle-ssg kyle-ssg requested a review from rolodato June 4, 2024 12:32
@github-actions github-actions bot added the front-end Issue related to the React Front End Dashboard label Jun 4, 2024
@kyle-ssg kyle-ssg linked an issue Jun 4, 2024 that may be closed by this pull request
Enable autocomplete for login fields #4100
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 4, 2024 •
edited
Loading

Uffizzi Preview deployment-52618 was deleted.

@kyle-ssg kyle-ssg changed the title fix:Add autocomplete for login fix: Add autocomplete for login Jun 4, 2024
@github-actions github-actions bot added the fix label Jun 4, 2024
novakzaballa
novakzaballa approved these changes Jun 4, 2024
View reviewed changes
Copy link
Contributor

@novakzaballa novakzaballa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kyle-ssg kyle-ssg added this pull request to the merge queue Jun 4, 2024
Merged via the queue into main with commit 5ffdd51 Jun 4, 2024
21 checks passed
@kyle-ssg kyle-ssg deleted the fix/add-autocomplete-for-login branch June 4, 2024 12:48
@dabeeeenster dabeeeenster mentioned this pull request Jun 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@novakzaballa novakzaballa novakzaballa approved these changes

@rolodato rolodato Awaiting requested review from rolodato

Assignees
No one assigned
Labels
fix front-end Issue related to the React Front End Dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable autocomplete for login fields
2 participants
@kyle-ssg @novakzaballa