Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add permissions and roles e2e tests #4172

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

novakzaballa
Copy link
Contributor

@novakzaballa novakzaballa commented Jun 17, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Add e2e test for permissions and roles.

Closes #3854

How did you test this code?

We needed the branch test: seed data for permission and roles e2e tests to test it

Copy link

vercel bot commented Jun 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 7, 2024 0:57am
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 7, 2024 0:57am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Oct 7, 2024 0:57am

@github-actions github-actions bot added front-end Issue related to the React Front End Dashboard testing labels Jun 17, 2024
Copy link
Contributor

github-actions bot commented Jun 17, 2024

Uffizzi Ephemeral Environment deployment-56970

☁️ https://app.uffizzi.com/github.com/Flagsmith/flagsmith/pull/4172

📄 View Application Logs etc.

What is Uffizzi? Learn more!

@novakzaballa novakzaballa changed the title test: add permissions and roles e2e tests test: Add permissions and roles e2e tests Jun 18, 2024
Copy link

codecov bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.20%. Comparing base (e65c8da) to head (e838de4).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4172   +/-   ##
=======================================
  Coverage   97.20%   97.20%           
=======================================
  Files        1171     1171           
  Lines       40640    40640           
=======================================
  Hits        39506    39506           
  Misses       1134     1134           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@novakzaballa novakzaballa requested a review from a team as a code owner August 12, 2024 15:56
@novakzaballa novakzaballa requested review from kyle-ssg and removed request for a team August 12, 2024 15:56
@github-actions github-actions bot added testing and removed testing labels Aug 12, 2024
@novakzaballa
Copy link
Contributor Author

I’m resolving the conflicts by merging. Some new permission tests stopped working, but this has already been fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
front-end Issue related to the React Front End Dashboard testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add e2e tests for permissions and roles
3 participants