feat: Create change requests for segments #4265
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
github-actions
bot
added
api
Uffizzi Ephemeral Environment
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4265 +/- ##
==========================================
+ Coverage 97.20% 97.22% +0.01%
==========================================
Files 1171 1177 +6
Lines 40640 40803 +163
==========================================
+ Hits 39506 39671 +165
+ Misses 1134 1132 -2 ☔ View full report in Codecov by Sentry. |
github-actions
bot
added
feature
github-actions
bot
added
feature
github-actions
bot
added
feature
github-actions
bot
added
feature
github-actions
bot
added
feature
github-actions
bot
added
feature
github-actions
bot
added
feature
github-actions
bot
added
feature
github-actions
bot
added
feature
github-actions
bot
added
feature
github-actions
bot
added
feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR works in concert with this other PR on the workflows repo.
This PR introduces many changes to support the addition of segments in change requests. The primary logic around transferring change request segment data into the target segment data involves re-using logic that was originally written for the segment versioning.
Due to the primary manager (
.objects) now including versioned or change requested segments copies, some amount of work was necessary to get all the aspects of the existing code to pass. The.live_objectsmanager is used for segments that are not merely versions or change request segments but in some places manually filtering segments was the only solution.How did you test this code?
Added tests across the test suite, including new tests for duplicate segments to test filtering, as well as tests located in with the other workflows PR to get coverage of edge cases.